- Jun 03, 2019
-
-
Lioncash authored
We can make this message more meaningful by indicating the location the screenshot has been saved to. We can also log out whenever a screenshot could not be saved (e.g. due to filesystem permissions or some other reason).
-
Lioncash authored
Treating it as a u16 can result in a sign-conversion warning when performing arithmetic with it, as u16 promotes to an int when aritmetic is performed on it, not unsigned int. This also makes the interface more uniform, as the layout interface now operates on u32 across the board.
-
Lioncash authored
This class contains non-trivial members, so we should default the destructor's definition within the cpp file.
-
Lioncash authored
Same thing (for platforms we support), less reading.
-
Lioncash authored
This function is defined as taking an int, not a bool.
-
Lioncash authored
We can just pass a pointer to GMainWindow directly and make it a requirement of the interface. This makes the interface a little safer, since this would technically otherwise allow any random QWidget to be the parent of a render window, downcasting it to GMainWindow (which is undefined behavior).
-
Lioncash authored
We can just invoke these functions by qualifying the object name before the function.
-
- May 30, 2019
-
-
Zach Hilman authored
-
- May 26, 2019
-
-
Zach Hilman authored
-
Zach Hilman authored
-
Zach Hilman authored
Preserves list of add ons and the icon, which are the two costliest parts of game list population.
-
Zach Hilman authored
-
ReinUsesLisp authored
There's no performance improvement in passing an unsigned pair by reference.
-
- May 25, 2019
-
-
Lioncash authored
Nothing from the hotkeys dialog relies on this call occurring, and is already called from the dialog that calls applyConfiguration().
-
Lioncash authored
Avoids mentioning the user and formalizes the error itself.
-
Lioncash authored
critical() is intended for critical/fatal errors that threaten the overall stability of an application. A user entering a conflicting key sequence is neither of those.
-
Lioncash authored
We don't need to extract the entire set of hotkeys into a list and then iterate through it. We can traverse the list and early-exit if we're able to.
-
Lioncash authored
1. This is something that should be solely emitted by the hotkey dialog itself 2. This is functionally unused, given there's nothing listening for the signal.
-
Lioncash authored
The previous code was all "smushed" together wasn't really grouped together that well. This spaces things out and separates them by relation to one another, making it easier to visually parse the individual sections of code that make up the constructor.
-
Lioncash authored
QDialogButtonBoxes are horizontal by default.
-
Lioncash authored
Now that all of our code is compilable with implicit QString conversions, we can enforce it at compile-time by disabling them.
-
Lioncash authored
This isn't actually used anywhere, so it can be removed.
-
Lioncash authored
Given the std::optional can contain an object type that heap allocates, we can use std::move to avoid an unnecessary copy/allocation from occurring.
-
Lioncash authored
Qt uses a signed value to represent container sizes, so this was causing a sign mismatch warning.
-
Lioncash authored
Allows the software keyboard applet code to compile with implicit string conversions disabled.
-
Lioncash authored
Allows the error applet to build successfully with implicit string conversions disabled.
-
Lioncash authored
-
- May 21, 2019
-
-
ReinUsesLisp authored
-
Lioncash authored
Given the array is a private static array, we can just make it internally linked to hide it from external code. This also allows us to remove an inclusion within the header.
-
Lioncash authored
Allows the configuration code to build successfully with implicit string conversions disabled.
-
- May 20, 2019
-
-
Lioncash authored
Allows the game list code to compile successfully with implicit string conversions disabled.
-
Lioncash authored
Allows the game list worker code to compile successfully with implicit string conversions disabled.
-
Lioncash authored
SMDH is a metadata format used in some executable formats for the Nintendo 3DS. Switch executables don't utilize this metadata format, so this just a holdover from Citra and can be corrected.
-
Lioncash authored
Allows the game list item code to build with implicit string conversions disabled.
-
Lioncash authored
Allows the loading screen code to compile with implicit string conversions disabled. While we're at it remove unnecessary const usages, and add it to nearby variables where appropriate.
-
Lioncash authored
Allows the bootmanager code to compile with implicit string conversions disabled.
-
Lioncash authored
Allows the util code to build with implicit string conversions disabled.
-
- May 19, 2019
-
-
Lioncash authored
Allows the web config code to compile with implicit string conversions disabled. We can also deduplicate the calls to create the pixmap.
-
Lioncash authored
Allows the system config code to build successfully with implicit string conversions disabled.
-
Lioncash authored
This is a user-facing string, so it should be marked as translatable.
-