- May 20, 2019
- May 19, 2019
-
-
Fernando Sahmkow authored
This reverts a tested behavior on delay slots not exiting if the exit flag is set. Currently new tests are required in order to ensure this behavior.
-
Lioncash authored
Allows the web config code to compile with implicit string conversions disabled. We can also deduplicate the calls to create the pixmap.
-
Lioncash authored
Allows the system config code to build successfully with implicit string conversions disabled.
-
Lioncash authored
This is a user-facing string, so it should be marked as translatable.
-
Lioncash authored
Allows the per-game configuration to be successfully built with implicit string conversions disabled.
-
Lioncash authored
Deduplicates array accesses and uses a named variable where appropriate.
-
Lioncash authored
Allows the advanced mouse configuration code to build with implicit string conversions disabled.
-
Lioncash authored
Rather than repeatedly index arrays that have quite a large array index, we can just use a named variable instead.
-
Lioncash authored
Allows the player input configuration code to compile with implicit string conversions disabled.
-
Lioncash authored
These are user-facing strings, so they should be localizable.
-
Lioncash authored
Allows the general configuration code to successfully compile with implicit string conversions disabled.
-
Lioncash authored
Allows the gamelist configuration code to compile with implicit string conversions disabled.
-
Lioncash authored
Avoids using the system accessor more than necessary, and ensures that both dialog boxes see the same power on state.
-
Lioncash authored
We can just use qOverload here to tidy up the function cast.
-
Lioncash authored
Allows the audio configuration code to build with implicit string conversions disabled.
-
Fernando Sahmkow authored
This is a measure to avoid crashes on command list reading as an empty command_list is considered a NOP.
-
Lioncash authored
constexpr internally links by default, so the inline specifier is unnecessary.
-
Lioncash authored
Many of these constructors don't even need to be templated. The only ones that need to be templated are the ones that actually make use of the parameter pack. Even then, since std::vector accepts an initializer list, we can supply the parameter pack directly to it instead of creating our own copy of the list, then copying it again into the std::vector.
-
Lioncash authored
shader/shader_ir: Remove unnecessary template parameter packs from Operation() overloads where applicable These overloads don't actually make use of the parameter pack, so they can be turned into regular non-template function overloads.
-
Lioncash authored
These don't actually modify instance state, so they can be marked as const member functions
-
Lioncash authored
This has been left unused since the removal of the vestigial surface viewer. Given it has no uses left, this can be removed as well.
-
Lioncash authored
Given the class contains quite a lot of non-trivial types, place the constructor and destructor within the cpp file to avoid inlining construction and destruction code everywhere the class is used.
-
Lioncash authored
Avoids performing copies into the pair being returned. Instead, we can just move the resources into the pair, avoiding the need to make copies of both the std::string and ShaderEntries struct.
-
Lioncash authored
Given the offset is assigned a fixed value in the constructor, we can just assign it directly and get rid of the need to write the name of the variable again in the constructor initializer list.
-
Lioncash authored
Given the disk shader cache contains non-trivial types, we should default it in the cpp file in order to prevent inlining of the complex destruction logic.
-
Lioncash authored
The standard library expects hash specializations that don't throw exceptions. Make this explicit in the type to allow selection of better code paths if possible in implementations.
-
Lioncash authored
We don't need to load the code into a vector and then construct a string over the data. We can just create a string with the necessary size ahead of time, and read the data directly into it, getting rid of an unnecessary heap allocation.
-
Lioncash authored
std::move does nothing when applied to a const variable. Resources can't be moved if the object is immutable. With this change, we don't end up making several unnecessary heap allocations and copies.
-
Lioncash authored
Booleans don't have a guaranteed size, but we still want to have them integrate into the disk cache system without needing to actually use a different type. We can do this by supplying non-template overloads for the bool type. Non-template overloads always have precedence during function resolution, so this is safe to provide. This gets rid of the need to smatter ternary conditionals, as well as the need to use u8 types to store the value in.
-
Lioncash authored
This is a user-facing string, so it should be marked as translatable.
-
Lioncash authored
Allows the graphics breakpoints to compile with implicit string conversions disabled.
-
Lioncash authored
This allows the microprofile widget to compile with implicit string conversions disabled.
-
Lioncash authored
Allows compiling the wait tree widget with implicit string conversions disabled.
-
Lioncash authored
Currently, this overload isn't used, so this wasn't actually hit in any code, only the float overload is used.
-
- May 18, 2019
-
-
Lioncash authored
These are only used from within this translation unit, so they don't need to have external linkage. They were intended to be marked with this anyways to be consistent with the other service functions.
-
Lioncash authored
Previously this would fall through and return successfully, despite being an out of bounds read or write.
-
Lioncash authored
Renames the members to more accurately indicate what they signify. "OneShot" and "Sticky" are kind of ambiguous identifiers for the reset types, and can be kind of misleading. Automatic and Manual communicate the kind of reset type in a clearer manner. Either the event is automatically reset, or it isn't and must be manually cleared. The "OneShot" and "Sticky" terminology is just a hold-over from Citra where the kernel had a third type of event reset type known as "Pulse". Given the Switch kernel only has two forms of event reset types, we don't need to keep the old terminology around anymore.
-
ReinUsesLisp authored
-