- May 26, 2019
- May 25, 2019
-
-
Lioncash authored
Nothing from the hotkeys dialog relies on this call occurring, and is already called from the dialog that calls applyConfiguration().
-
Lioncash authored
Avoids mentioning the user and formalizes the error itself.
-
Lioncash authored
critical() is intended for critical/fatal errors that threaten the overall stability of an application. A user entering a conflicting key sequence is neither of those.
-
Lioncash authored
We don't need to extract the entire set of hotkeys into a list and then iterate through it. We can traverse the list and early-exit if we're able to.
-
Lioncash authored
1. This is something that should be solely emitted by the hotkey dialog itself 2. This is functionally unused, given there's nothing listening for the signal.
-
Lioncash authored
The previous code was all "smushed" together wasn't really grouped together that well. This spaces things out and separates them by relation to one another, making it easier to visually parse the individual sections of code that make up the constructor.
-
Lioncash authored
QDialogButtonBoxes are horizontal by default.
-
bunnei authored
yuzu/main: Specify string conversions explicitly
-
bunnei authored
gl_shader_cache: Use shared contexts to build shaders in parallel at boot
-
Lioncash authored
Now that all of our code is compilable with implicit QString conversions, we can enforce it at compile-time by disabling them.
-
Lioncash authored
This isn't actually used anywhere, so it can be removed.
-
Lioncash authored
Given the std::optional can contain an object type that heap allocates, we can use std::move to avoid an unnecessary copy/allocation from occurring.
-
Lioncash authored
Qt uses a signed value to represent container sizes, so this was causing a sign mismatch warning.
-
Lioncash authored
Allows the software keyboard applet code to compile with implicit string conversions disabled.
-
Lioncash authored
Allows the error applet to build successfully with implicit string conversions disabled.
-
Lioncash authored
-
- May 24, 2019
-
-
bunnei authored
shader/memory: Implement generic memory stores and loads (ST and LD)
-
bunnei authored
yuzu/configuration/config: Specify string conversions explicitly
-
bunnei authored
Port citra-emu/citra#4716: "HLE/IPC: HLEContext can memorize the client thread and use it for SleepClientThread"
-
bunnei authored
externals: Update glad to support OpenGL 4.6 compatibility profile
-
- May 23, 2019
-
-
Lioncash authored
While we're at it, also invert the conditional into a guard clause.
-
Lioncash authored
nullptr was being returned in the error case, which, at a glance may seem perfectly OK... until you realize that std::string has the invariant that it may not be constructed from a null pointer. This means that if this error case was ever hit, then the application would most likely crash from a thrown exception in std::string's constructor. Instead, we can change the function to return an optional value, indicating if a failure occurred.
-
Lioncash authored
These are already present within the header, so they don't need to be repeated in the cpp file.
-
Lioncash authored
Makes the parameter ordering consistent, and also makes the filename parameter a std::string. A std::string would be constructed anyways with the previous code, as IOFile's only constructor with a filepath is one taking a std::string. We can also make WriteStringToFile's string parameter utilize a std::string_view for the string, making use of our previous changes to IOFile.
-
Lioncash authored
The file stream open functions have supported std::string overloads since C++11, so we don't need to use c_str() here. Same behavior, less code.
-
Lioncash authored
We don't need to force the usage of a std::string here, and can instead use a std::string_view, which allows writing out other forms of strings (e.g. C-style strings) without any unnecessary heap allocations.
-
Lioncash authored
This allows for forming comment nodes without making unnecessary copies of the std::string instance. e.g. previously: Comment(fmt::format("Base address is c[0x{:x}][0x{:x}]", cbuf->GetIndex(), cbuf_offset)); Would result in a copy of the string being created, as CommentNode() takes a std::string by value (a const ref passed to a value parameter results in a copy). Now, only one instance of the string is ever moved around. (fmt::format returns a std::string, and since it's returned from a function by value, this is a prvalue (which can be treated like an rvalue), so it's moved into Comment's string parameter), we then move it into the CommentNode constructor, which then moves the string into its member variable).
-
Lioncash authored
Keeps the shader code file endings consistent.
-
Lioncash authored
Amends cases where we were using things that were indirectly being satisfied through other headers. This way, if those headers change and eliminate dependencies on other headers in the future, we don't have cascading compilation errors.
-
- May 22, 2019
-
-
Lioncash authored
-
- May 21, 2019
-
-
ReinUsesLisp authored
Now that we have an OpenGL compatibility profile we might want to use OpenGL compatibility symbols that are not available in our current glad. This commit has been generated with https://glad.dav1d.de/ with all extensions enabled and OpenGL 4.6 compatibility profile.
-
Lioncash authored
This accidentally slipped through a rebase.
-
ReinUsesLisp authored
-
ReinUsesLisp authored
-
ReinUsesLisp authored
-
ReinUsesLisp authored
-
Lioncash authored
Given the array is a private static array, we can just make it internally linked to hide it from external code. This also allows us to remove an inclusion within the header.
-
Lioncash authored
Allows the configuration code to build successfully with implicit string conversions disabled.
-