constexpr internally links by default, so the inline specifier is
unnecessary.

Many of these constructors don't even need to be templated. The only
ones that need to be templated are the ones that actually make use of
the parameter pack.

Even then, since std::vector accepts an initializer list, we can supply
the parameter pack directly to it instead of creating our own copy of
the list, then copying it again into the std::vector.

shader/shader_ir: Remove unnecessary template parameter packs from Operation() overloads where applicable

These overloads don't actually make use of the parameter pack, so they
can be turned into regular non-template function overloads.

These don't actually modify instance state, so they can be marked as
const member functions

Given the class contains quite a lot of non-trivial types, place the
constructor and destructor within the cpp file to avoid inlining
construction and destruction code everywhere the class is used.

Compatibility profile and the disk shader cache settings shouldn't
be changed at runtime. This aims to address that shadowing those
options.

The SDL2 frontend never bound the OpenGL context, resulting on a white
screen and no-ops all over the backend.

Corrects the typo in its name and marks the function as a const member
function, given it doesn't actually modify memory manager state.

Prevents implicit converting constructions of the memory manager.

Makes the class less surprising when it comes to forward declaring the
type, and also prevents inlining the destruction code of the class,
given it contains non-trivial types.

Corrects references to non-existent parameters and corrects typos.

These are able to be omitted from the declaration of functions, since
they don't do anything at the type system level. The definitions of the
functions can retain the use of const though, since they make the
variables immutable in the implementation of the function where they're
used.

Silences a -Wreorder warning.

This isn't used at all, so it can be removed.

This variable is unused entirely, so it can be removed.

Instead of retrieving the data from the std::variant instance, we can
just check if the variant contains that type of data.

This is essentially the same behavior, only it returns a bool indicating
whether or not the type in the variant is currently active, instead of
actually retrieving the data.

Silences a few compilation warnings.

By default, MSVC doesn't use standards-compliant volatile semantics.
This makes it behave in a standards-compliant manner, making
expectations more uniform across compilers.

The behavior of the Hotkey constructor is already accomplished via in-class member
initializers, so the constructor is superfluous here.

For similar reasons to the previous change, we move this to a single
function, so we don't need to duplicate the conversion logic in several
places within main.cpp.

Specifies the conversions explicitly to avoid implicit conversions from
const char* to QString. This makes it easier to disable implicit QString
conversions in the future.

In this case, the implicit conversion was technically wrong as well. The
implicit conversion treats the input strings as ASCII characters. This
would result in an incorrect conversion being performed in the rare case
a branch name was created with a non-ASCII Unicode character, likely
resulting in junk being displayed.

Keeps the code consistent in regards to how the buttons are referred to.

The C++ standard allows constexpr variables declared with the extern
keyword to have external linkage. Previously MSVC wasn't abiding by
this. This just makes the compiler more standards compliant during
builds.

Given we currently don't make use of anything that would break by this,
this is safe to enable.

Makes it much nicer to visually scan the options. This also starts the
flag descriptions from the same column for the same reason.

Recent changes to memory-related code resulted in this being unused, so
we can remove it.

The backend is not used until we decide to submit the testcase/telemetry, and creating it early prevents users from updating the credentials properly while the games are running.

This isn't used anywhere, so we can get rid of it.

Ensures that -Wall is always active as a compilation flag.

Makes use of src, so it's not considered unused.

Introduced in 72477731. This is only
necessary within header files.

This class is used in a polymorphic context, so destruction of the
context will lead to undefined behavior if the destructor isn't virtual.

Instead of asserting on already stored shader variants, silently skip them.
This shouldn't be happening but when a shader is invalidated and it is
not stored in the shader cache, this assert would hit and save that
shader anyways when the asserts are disabled.

By adding the missing layer offset in ASTC compression.

Unintentionally introduced in 552d5071

The state of these service calls are still the same in version 8.0.0.