- Aug 05, 2018
-
-
Lioncash authored
Keeps everything under the same namespace. While we're at it, enclose them all within an inner anonymous namespace.
-
Lioncash authored
In all cases, a virtual address is being passed in, not a physical one.
-
David Marcec authored
-
David Marcec authored
-
- Aug 04, 2018
-
-
Lioncash authored
Adds the basic skeleton of the arp services based off the information provided by Switch Brew.
-
Lioncash authored
These don't do anything within .cpp files (we don't include cpp files, so...)
-
Lioncash authored
These functions should only be given trivially-copyable types.
-
Lioncash authored
This function doesn't directly depend on class state, so it can be hidden entirely from the interface in the cpp file.
-
Lioncash authored
This doesn't modify member state, so it can be made const.
-
Lioncash authored
-
Lioncash authored
The benefit of std::string_view comes from the idea of avoiding copies (essentially acting as a non-owning view), however if we're just going to copy into a local variable immediately, there's not much benefit gained here.
-
Lioncash authored
This lets us indent the majority of the code and places the error case first.
-
Lioncash authored
gl_shader_manager: Amend sign differences in an assertion comparison in SetShaderUniformBlockBinding() Ensures both operands have the same sign in the comparison. While we're at it, we can get rid of the redundant casting of ub_size to an int. This type will always be trivial and alias a built-in type (not doing so would break backwards compatibility at a standard level).
-
Lioncash authored
This amends cases where crashes can occur that were missed due to the odd way the previous code was set up (using 3DS memory regions that don't exist).
-
- Aug 03, 2018
-
-
Lioncash authored
-
Lioncash authored
Using member variables for referencing the segments array increases the size of the class in memory for little benefit. The same behavior can be achieved through the use of accessors that just return the relevant segment.
-
Lioncash authored
This is just unused code, so we may as well get rid of it.
-
Lioncash authored
Given this has no definition, we can just remove it entirely.
-
Lioncash authored
This variable was being incremented, but we were never actually using it.
-
Lioncash authored
This function doesn't modify class state, so it can be made const.
-
Lioncash authored
Removes leftover code from citra that isn't needed.
-
David authored
Added ability to change username & language code in the settings ui. Added IProfile::Get and SET::GetLanguageCode for libnx tests (#851)
-
Lioncash authored
Makes the signal/slot connections type-safe instead of string-based.
-
Lioncash authored
Avoids unnecessary atomic reference count increments and decrements
-
Lioncash authored
-
- Aug 02, 2018
-
-
greggameplayer authored
-
Lioncash authored
-
Lioncash authored
Makes our immutable state explicit.
-
Lioncash authored
These two variables correspond to address ranges.
-
Lioncash authored
Avoids using a u32 to compare against a range of size_t, which can be a source of warnings. While we're at it, compress a std::tie into a structured binding.
-
Lioncash authored
This function only reads the data being referenced, it doesn't modify it, so we can turn the reference into a const reference.
-
Lioncash authored
This function isn't used outside of this translation unit, so we can make it internally linked.
-
Lioncash authored
This wasn't being used for anything, so it can be removed.
-
Lioncash authored
The lambda elements should be taken by const reference here, and we can move the virtual directory passed to ReplaceFileWithSubdirectory()
-
Lioncash authored
Gets rid of the use of a raw C array.
-
Lioncash authored
gl_shader_manager: Take ShaderSetup instances by const reference in UseProgrammableVertexShader() and UseProgrammableFragmentShader() Avoids performing unnecessary copies of 65560 byte sized ShaderSetup instances, considering it's only used as part of lookup and not modified. Given the parameters were already const, it's likely taking these parameters by reference was intended but the ampersand was forgotten.
-
Lioncash authored
Prevents potentially using the members uninitialized.
-
Lioncash authored
None of these files are used in any meaningful way. They're just leftovers from citra. Also has the benefit of getting rid of an unused global variable.
-
Lioncash authored
Adds the basic skeleton for the mig:usr service based off information provided by Switch Brew.
-
Lioncash authored
This makes the Buffer::Tag usage consistent with the Stream class's prototype of GetTagsAndReleaseBuffers().
-