Makes the casing consistent with all of our general function naming
conventions.

Makes the interface more type-safe and consistent in terms of return
values.

Removes unused overloads, simplifying the overall interface,
deduplicating some code.

Treating it as a u16 can result in a sign-conversion warning when
performing arithmetic with it, as u16 promotes to an int when aritmetic
is performed on it, not unsigned int.

This also makes the interface more uniform, as the layout interface now
operates on u32 across the board.

The contents of these includes aren't used anywhere in this translation
unit.

This is a hold-over from Citra and doesn't apply to yuzu.

This will automatically occur when the backend instance goes out of
scope at the end of the destructor's execution.

Makes the dependency explicit in the TelemetrySession's interface
instead of making it a hidden dependency.

This also revealed a hidden issue with the way the telemetry session was
being initialized. It was attempting to retrieve the app loader and log
out title-specific information. However, this isn't always guaranteed to
be possible.

During the initialization phase, everything is being constructed. It
doesn't mean an actual title has been selected. This is what the Load()
function is for. This potentially results in dead code paths involving
the app loader. Instead, we explicitly add this information when we know
the app loader instance is available.

NonCopyable is misleading here. It also makes the class non-moveable as
well, so we can be explicit about this.

Returns an object of type IAddOnContentLocationResolver for the provided StorageId.

Returns an object of type IRegisteredLocationResolver for the StorageId.

Returns an object of type ILocationResolver with the provided StorageId.

There's no performance improvement in passing an unsigned pair by
reference.

We can just make the conversion explicit instead of implicit here to
silence -Wsign-compare warnings.

This was previously performing a size_t == int comparison. Silences a
-Wsign-compare warning.

Previously, the code was accumulating data into a std::vector and then
tossing all of it away if a setting was disabled.

Instead, we can just check if it's disabled and do no work at all if
possible. If it's enabled, then we can append to the vector and
allocate.

Unlikely to impact usage much, but it is slightly less sloppy with
resources.

Removes two header dependencies related to file handling that aren't
actually used within the source file.

A few of the aoc service stubs/implementations weren't fully popping all
of the parameters passed to them. This ensures that all parameters are
popped and, at minimum, logged out.

Currently, this overload isn't used, so this wasn't actually hit in any
code, only the float overload is used.

Co-Authored-By: Mat M. <mathew1800@gmail.com>

These are only used from within this translation unit, so they don't
need to have external linkage. They were intended to be marked with this
anyways to be consistent with the other service functions.

Previously this would fall through and return successfully, despite
being an out of bounds read or write.

Renames the members to more accurately indicate what they signify.
"OneShot" and "Sticky" are kind of ambiguous identifiers for the reset
types, and can be kind of misleading. Automatic and Manual communicate
the kind of reset type in a clearer manner. Either the event is
automatically reset, or it isn't and must be manually cleared.

The "OneShot" and "Sticky" terminology is just a hold-over from Citra
where the kernel had a third type of event reset type known as "Pulse".
Given the Switch kernel only has two forms of event reset types, we
don't need to keep the old terminology around anymore.

This reduces the boilerplate that services have to write out the current thread explicitly. Using current thread instead of client thread is also semantically incorrect, and will be a problem when we implement multicore (at which time there will be multiple current threads)

This corrects cases where it was possible to write more entries into the
write buffer than were requested. Now, we check the size of the buffer
before actually writing into them.

We were also returning the wrong value for
GetAvailableLanguageCodeCount2(). This was previously returning 64, but
only 17 should have been returned. 64 entries is the size of the static
array used in MakeLanguageCode() within the service binary itself, but
isn't the actual total number of language codes present.

Recent changes to memory-related code resulted in this being unused, so
we can remove it.

The backend is not used until we decide to submit the testcase/telemetry, and creating it early prevents users from updating the credentials properly while the games are running.

This class is used in a polymorphic context, so destruction of the
context will lead to undefined behavior if the destructor isn't virtual.

Also introduced in REV5 was a variable-size audio command buffer. This
also affects how the size of the work buffer should be determined, so we
can add handling for this as well.

Thankfully, no other alterations were made to how the work buffer size
is calculated in 7.0.0-8.0.0. There were indeed changes made to to how
some of the actual audio commands are generated though (particularly in
REV7), however they don't apply here.

Introduced in REV5. This is trivial to add support for, now that
everything isn't a mess of random magic constant values.

All this is, is a change in data type sizes as far as this function
cares.

"Unmagics" quite a few magic constants within this code, making it much
easier to understand. Particularly given this factors out specific
sections into their own self-contained lambda functions.

Unintentionally introduced in 552d5071

kernel/svc: Make svcCreateThread/svcStartThread/svcSleepThread/svcExitThread calls show up in the debug log

These are actually quite important indicators of thread lifetimes, so
they should be going into the debug log, rather than being treated as
misc info and delegated to the trace log.