- Mar 09, 2019
-
-
Lioncash authored
This behavior also needs to be visible for MinGW builds as well.
-
Hexagon12 authored
-
Hexagon12 authored
-
ReinUsesLisp authored
-
ReinUsesLisp authored
-
ReinUsesLisp authored
-
- Mar 08, 2019
-
-
ReinUsesLisp authored
Instead of holding a reference that will get invalidated by dma_pushbuffer.pop(), hold it as a copy. This doesn't have any performance cost since CommandListHeader is 8 bytes long.
-
Lioncash authored
There's no real need to use a shared lifetime here, since we don't actually expose them to anything else. This is also kind of an unnecessary use of the heap given the objects themselves are so small; small enough, in fact that changing over to optionals actually reduces the overall size of the HLERequestContext struct (818 bytes to 808 bytes).
-
- Mar 07, 2019
-
-
Lioncash authored
This makes the class much more flexible and doesn't make performing copies with classes that contain a bitfield member a pain. Given BitField instances are only intended to be used within unions, the fact the full storage value would be copied isn't a big concern (only sizeof(union_type) would be copied anyways). While we're at it, provide defaulted move constructors for consistency.
-
Lioncash authored
This function didn't have a definition, so we can remove it to prevent accidentally attempting to use it.
-
Lioncash authored
Moves the data members to satisfy the order they're declared as in the constructor initializer list. Silences a -Wreorder warning.
-
Lioncash authored
Because of the recent separation of GPU functionality into sync/async variants, we need to mark the destructor virtual to provide proper destruction behavior, given we use the base class within the System class. Prior to this, it was undefined behavior whether or not the destructor in the derived classes would ever execute.
-
Lioncash authored
service/audio/audout_u: Only actually stop the audio stream in StopAudioOut if the stream is playing The service itself only does further actions if the stream is playing. If the stream is already stopped, then it just exits successfully.
-
bunnei authored
-
bunnei authored
-
bunnei authored
-
bunnei authored
-
bunnei authored
-
bunnei authored
-
bunnei authored
-
bunnei authored
-
bunnei authored
-
bunnei authored
-
- Mar 06, 2019
-
-
fearlessTobi authored
-
Lioncash authored
Previously we were overwriting the error case with a success code further down (which is definitely not what we should be doing here).
-
Lioncash authored
We already have the thread instance that was created under the current process, so we can just pass the handle table of it along to retrieve the owner of the mutex.
-
Lioncash authored
Removes a few unnecessary dependencies on core-related machinery, such as the core.h and memory.h, which reduces the amount of rebuilding necessary if those files change. This also uncovered some indirect dependencies within other source files. This also fixes those.
-
Lioncash authored
Makes it much nicer to locally reason about server session behavior, as part of its functionality isn't placed around other classes.
-
Lioncash authored
These can be made private, as they aren't accessed in contexts that require them to be public.
-
- Mar 05, 2019
-
-
Lioncash authored
Places all error codes in an easily includable header. This also corrects the unsupported error code (I accidentally used the hex value when I meant to use the decimal one).
-
Lioncash authored
Allows getting rid of reliance on the global accessor functions and instead operating on the provided system instance.
-
Lioncash authored
- Invert conditions into guard clases where applicable. - Mark std::vector parameter of WakeThreads as const
-
Lioncash authored
Places all of the functions for address arbiter operation into a class. This will be necessary for future deglobalizing efforts related to both the memory and system itself.
-
Lioncash authored
This isn't needed anymore, according to Hexagon
-
Lioncash authored
This is a TODO carried over from Citra that doesn't apply here.
-
Lioncash authored
Removes a few inclusion dependencies from the headers or replaces existing ones with ones that don't indirectly include the required headers. This allows removing an inclusion of core/memory.h, meaning that if the memory header is ever changed in the future, it won't result in rebuilding the entirety of the HLE services (as the IPC headers are used quite ubiquitously throughout the HLE service implementations).
-
- Mar 04, 2019
-
-
Zach Hilman authored
Addresses issues where a user in fullscreen could not exit some web applets without leaving fullscreen.
-
Lioncash authored
Significantly tidies up two guard conditionals.
-
Lioncash authored
Makes the interface uniform when it comes to checking various memory regions.
-
Lioncash authored
Given we already pass in a reference to the kernel that the shared memory instance is created under, we can just use that to check the current process, rather than using the global accessor functions. This allows removing direct dependency on the system instance entirely.
-