If this path was ever taken, a runtime exception would occur due to the
lack of a formatting specifier to insert the error code into the format
string.

Places the documentation comments with the rest of SDLState's member
function documentation.

Adds another underscore to clearly indicate the axis names.

Make it explicit that these aren't modified elsewhere (either through
functions by reference, or by other operations).

Its prototype declared at the top of the translation unit contains the
static qualifier, so the function itself should also contain it to make
it a proper internally linked function.

It's valid to static_cast a void pointer back into its proper type.

Same behavior, but without a potential need to unnecessarily default
construct a value.

The deleter can just be set in the constructor and maintained throughout
the lifetime of the object.

If a contained pointer is null, then the deleter won't execute, so this
is safe to do. We don't need to swap it out with a version of a deleter
that does nothing.

Silences the final two warnings in SDL code.

Gets rid of a few unnecessary inclusion dependencies. It also uncovered
a few indirect inclusion dependencies being relied upon.

Makes the conversions explicit, as opposed to implicit.

Allows for things such as:

auto rect = Common::Rectangle{0, 0, 0, 0};

as opposed to being required to explicitly write out the underlying
type, such as:

auto rect = Common::Rectangle<int>{0, 0, 0, 0};

The only requirement for the deduction is that all constructor arguments
be the same type.

mii: Implement MiiManager backend and several mii service commands

yuzu: Implement a caching mechanism for the game list

 shader: Implement S2R Tid{XYZ} and CtaId{XYZ} 

 yuzu_cmd: Split emu_window OpenGL implementation into its own file 

loader/nso, core/core_timing_util: Silence sign-comparison warning

gl_shader_gen: Always declare extensions after the version declaration 

The intention behind this commit is to hint someone inspecting an
apitrace dump to ignore this ill-formed GLSL code.

This addresses a bug on geometry shaders where code was being written
before all #extension declarations were done. Ref to #2523

Preserves list of add ons and the icon, which are the two costliest parts of game list population.

There's no performance improvement in passing an unsigned pair by
reference.

renderer_opengl/utils: Use a std::string_view with LabelGLObject()

service/aoc_u: Minor cleanup

common/file_util: Minor cleanup

configure_hotkeys: Minor cleanup

We can just make the conversion explicit instead of implicit here to
silence -Wsign-compare warnings.

This was previously performing a size_t == int comparison. Silences a
-Wsign-compare warning.

Nothing from the hotkeys dialog relies on this call occurring, and is
already called from the dialog that calls applyConfiguration().

Avoids mentioning the user and formalizes the error itself.

critical() is intended for critical/fatal errors that threaten the
overall stability of an application. A user entering a conflicting key
sequence is neither of those.

We don't need to extract the entire set of hotkeys into a list and then
iterate through it. We can traverse the list and early-exit if we're
able to.

1. This is something that should be solely emitted by the hotkey dialog
itself
2. This is functionally unused, given there's nothing listening for the
signal.

The previous code was all "smushed" together wasn't really grouped
together that well.

This spaces things out and separates them by relation to one another,
making it easier to visually parse the individual sections of code that
make up the constructor.