video_core/shader: Resolve instances of variable shadowing

Silences a few -Wshadow warnings.

ci: Add build name to archive root folder

hid/npad: Minor cleanup

shader_ir/memory: Ignore global memory when tracking fails

gl_shader_decompiler/vk_shader_decompiler: Resolve implicit fallthrough cases

Ignore global memory operations instead of invoking undefined behaviour
when constant buffer tracking fails and we are blasting through asserts,
ignore the operation.

In the case of LDG this means filling the destination registers with
zeroes; for STG this means ignore the instruction as a whole.

The default behaviour is still to abort execution on failure.

maxwell_3d: Reduce FlushMMEInlineDraw logging to Trace

core: Fix clang-format errors.

Fix null pointer dereference.

video_core/shader/ast: Minor changes to ASTPrinter

These can also trivially be made const member functions, with the
addition of a few consts.

Given all visiting functions never modify the nodes, we can trivially
make this a const member function.

vk_shader_decompiler: Mark operator() function parameters as const references

This member already has an accessor, so there's no need for it to be
public.

The returned string is simply a substring of our constexpr tabs
string_view, so we can just use a string_view here as well, since the
original string_view is guaranteed to always exist.

Now the function is fully non-allocating.

It's never used outside of this class, so we can narrow its scope down.

This can be confusing, given "ident" is generally used as a shorthand
for "identifier".

Makes a few strings nicer to read and also eliminates a bit of string
churn with operator+.

dmnt_cheat_vm: Correct register Restore and ClearRegs behavior

These parameters aren't actually modified in any way, so they can be
made const references.

Previously these were performing the same behavior as the Save and
ClearSaved opcode types.

Implement a series of ASTC formats and R4G4B4A4 format

video_core/macro_interpreter: Make definitions of most private enums/unions hidden

service/apm/controller: Minor interface changes

We should be setting the connection state to true, otherwise we aren't
actually making the controllers connected like the function name
indicates.

core: Resolve -Wreorder warnings

While not an issue, it does prevent fallthrough from occurring if
anything is ever added after this case (unlikely to occur, but this
turns a trivial "should not cause issues" into a definite "won't cause
issues).

Performs the same behavior, but is built into the core language itself.

No functional change.

The const qualified variant can also be called in non-const contexts, so
we can remove the non-const variant to eliminate a bit of code
duplication.

Clearly separate these from the variable declarations to make them more
visible.

This allows the implementation of these types to change without
requiring a rebuild of everything that includes the macro interpreter
header.

Amends the initializer lists to be ordered in the same manner that
they're declared within the class.

Amends the initializer lists to be ordered in the same manner that
they're declared within the class.

While a map is an OK way to do lookups (and usually recommended in most
cases), this is a map that lives for the entire duration of the program
and only deallocates its contents when the program terminates.

Given the total size of the map is quite small, we can simply use a
std::array of pairs and utilize std::find_if to perform the same
behavior without loss of performance.

This eliminates a static constructor and places the data into the
read-only segment.

While we're at it, we can also handle malformed inputs instead of
directly dereferencing the resulting iterator.

This doesn't modify instance state, so it can be made const qualified.