- Aug 06, 2018
-
-
Lioncash authored
There's no need to keep these separate from one another.
-
mailwl authored
-
Lioncash authored
Keeps the code consistent.
-
Lioncash authored
Previously, the prototype wasn't matching the definition, which has a Processor parameter before the destination address.
-
Lioncash authored
These aren't necessary, as value-wise const only matters in the definition.
-
Lioncash authored
Makes the alias a little more readable from left-to-right.
-
Lioncash authored
Gets rid of the need to hardcode the type in multiple places. This will now be deduced automatically, based off the elements in the container being provided to the algorithm.
-
- Aug 05, 2018
-
-
Lioncash authored
Rather than having to type out the full std::map type signature, we can just use a straightforward alias. While we're at it, rename GetBreakpointList to GetBreakpointMap, which makes the name more accurate. We can also get rid of unnecessary u64 static_casts, since VAddr is an alias for a u64.
-
Lioncash authored
Keeps everything under the same namespace. While we're at it, enclose them all within an inner anonymous namespace.
-
Lioncash authored
In all cases the vector being supplied is empty, so we can just return by value in these instances.
-
Lioncash authored
In all cases, a virtual address is being passed in, not a physical one.
-
bunnei authored
-
bunnei authored
-
David Marcec authored
-
David Marcec authored
-
- Aug 04, 2018
-
-
bunnei authored
-
bunnei authored
-
Lioncash authored
Adds the basic skeleton of the arp services based off the information provided by Switch Brew.
-
Lioncash authored
These don't do anything within .cpp files (we don't include cpp files, so...)
-
Lioncash authored
These functions should only be given trivially-copyable types.
-
Lioncash authored
This function doesn't directly depend on class state, so it can be hidden entirely from the interface in the cpp file.
-
Lioncash authored
This doesn't modify member state, so it can be made const.
-
Lioncash authored
-
Lioncash authored
The benefit of std::string_view comes from the idea of avoiding copies (essentially acting as a non-owning view), however if we're just going to copy into a local variable immediately, there's not much benefit gained here.
-
bunnei authored
-
bunnei authored
-
bunnei authored
-
Lioncash authored
This lets us indent the majority of the code and places the error case first.
-
Lioncash authored
gl_shader_manager: Amend sign differences in an assertion comparison in SetShaderUniformBlockBinding() Ensures both operands have the same sign in the comparison. While we're at it, we can get rid of the redundant casting of ub_size to an int. This type will always be trivial and alias a built-in type (not doing so would break backwards compatibility at a standard level).
-
Lioncash authored
All calling code assumes that the rasterizer will be in a valid state, which is a totally fine assumption. The only way the rasterizer wouldn't be is if initialization is done incorrectly or fails, which is checked against in System::Init().
-
Lioncash authored
We move the initialization of the renderer to the core class, while keeping the creation of it and any other specifics in video_core. This way we can ensure that the renderer is initialized and doesn't give unfettered access to the renderer. This also makes dependencies on types more explicit. For example, the GPU class doesn't need to depend on the existence of a renderer, it only needs to care about whether or not it has a rasterizer, but since it was accessing the global variable, it was also making the renderer a part of its dependency chain. By adjusting the interface, we can get rid of this dependency.
-
Lioncash authored
This amends cases where crashes can occur that were missed due to the odd way the previous code was set up (using 3DS memory regions that don't exist).
-
- Aug 03, 2018
-
-
Lioncash authored
-
Lioncash authored
Using member variables for referencing the segments array increases the size of the class in memory for little benefit. The same behavior can be achieved through the use of accessors that just return the relevant segment.
-
Lioncash authored
This is just unused code, so we may as well get rid of it.
-
Lioncash authored
Given this has no definition, we can just remove it entirely.
-
Lioncash authored
This variable was being incremented, but we were never actually using it.
-
Lioncash authored
This function doesn't modify class state, so it can be made const.
-
Lioncash authored
Removes leftover code from citra that isn't needed.
-
David authored
Added ability to change username & language code in the settings ui. Added IProfile::Get and SET::GetLanguageCode for libnx tests (#851)
-