Nothing requires the shared owner ship here, so we can just return a
plain pointer.

* remove unnecessary if-statements

* Addressed feedback

Crypto revisions are hex numbers and this function only checks if the string is valid for stoul in base 16, so it should be isxdigit.

Prevents nullptr bug when trying to dump the RomFS of an NSP resulting from secondary_loader not being initialized.

Nothing from this enum is intended to be used outside of this function.

This retrieves:

if (curr_thread == handle_thread) {
   result = total_thread_ticks + (hardware_tick_count - last_context_switch_ticks);
} else if (curr_thread == handle_thread && sub_id == current_core_index) {
   result = hardware_tick_count - last_context_switch_ticks;
}

- This is an incomplete implementation. It was tested with Super Mario Party.

Kernel/Memory: Added a function to first a suitable guest address at which to allocate a region of a given size.

Prevents a potential bug when using RLE records in an IPS patch.

Updated based off the information provided by Hexkyz on Switchbrew.

This is just flat data, so it doesn't really need to be in the function
itself. This also allows deduplicating the constant for the backup size
in GetImageSize().

Silences compiler warnings related to truncation. This also introduces a
small helper function to perform the clamping of the image size.

Allows unindenting the other branch's code.

Now that we've gotten the innaccurate error codes out of the way, we can
finally toss away a bunch of these, trimming down the error codes to
ones that are actually used and knocking out two TODO comments.

This is more consistent with what the kernel does.

This is what the kernel does in this instance.

These are now entirely unused and can be removed.

Like with the previous change, the kernel doesn't return NOT_AUTHORIZED
here. It returns INVALID_THREAD_PRIORITY.

kernel/svc: Move and correct returned error code for invalid thread priorities in SetThreadPriority()

All priority checks are supposed to occur before checking the validity
of the thread handle, we're also not supposed to return
ERR_NOT_AUTHORIZED here.

The kernel appears to return 0xE601 for this situation. Particularly in
svcWaitSynchronization, svcReplyAndReceive, and svcGetThreadContext

The kernel appears to return 0xF601 for this case.

Now that we can actually use std::optional on macOS, we don't need to
continue using boost::optional here.

We shouldn't silently continue if loading failed, since the general
assumption is that no messages showing up implicitly indicates success.

This also gets rid of variable shadowing related to the lambda parameter
a little bit below this code as well.

This hasn't been used since ba8ff096

We can just call the function instead of duplicating the code here. This
also prevents an unused function warning.

We also don't need to take the lambda capture by reference. It's just a
u64 value, so by value is fine here.

Also gets rid of an unused variable.