1. 17 Mar, 2019 5 commits
  2. 16 Mar, 2019 11 commits
  3. 15 Mar, 2019 4 commits
  4. 14 Mar, 2019 1 commit
  5. 13 Mar, 2019 12 commits
  6. 12 Mar, 2019 6 commits
  7. 11 Mar, 2019 1 commit
    • Lioncash's avatar
      renderer_opengl/gl_global_cache: Replace indexing for assignment with insert_or_assign · 3350c0a7
      Lioncash authored
      The previous code had some minor issues with it, really not a big deal,
      but amending it is basically 'free', so I figured, "why not?".
      
      With the standard container maps, when:
      
      map[key] = thing;
      
      is done, this can cause potentially undesirable behavior in certain
      scenarios. In particular, if there's no value associated with the key,
      then the map constructs a default initialized instance of the value
      type.
      
      In this case, since it's a std::shared_ptr (as a type alias) that is
      the value type, this will construct a std::shared_pointer, and then
      assign over it (with objects that are quite large, or actively heap
      allocate this can be extremely undesirable).
      
      We also make the function take the region by value, as we can avoid a
      copy (and by extension with std::shared_ptr, a copy causes an atomic
      reference count increment), in certain scenarios when ownership isn't a
      concern (i.e. when ReserveGlobalRegion is called with an rvalue
      reference, then no copy at all occurs). So, it's more-or-less a "free"
      gain without many downsides.
      3350c0a7