- Aug 20, 2018
-
-
fearlessTobi authored
-
Lioncash authored
Avoids potentially leaving this variable uninitialized based off the loader failing to retrieve the ID value.
-
- Aug 19, 2018
-
-
David Marcec authored
-
- Aug 16, 2018
-
-
Lioncash authored
We can change this into an early-return if the filename is empty. There's no need to include all of the code within the if statement.
-
Lioncash authored
This is user-facing text, so it should be marked as translatable by Qt.
-
Lioncash authored
Gets rid of truncation warnings about conversion to int. While we're at it, we can also de-hardcode the buffer size being used.
-
- Aug 15, 2018
-
-
Lioncash authored
We can make the enum class type compatible with fmt by providing an overload of operator<<. While we're at it, perform proper bounds checking. If something exceeds the array, it should be a hard fail, because it's, without a doubt, a programmer error in this case.
-
- Aug 12, 2018
-
-
Zach Hilman authored
-
Zach Hilman authored
Avoids unnecessary rebuilds of control data on every layer of recursion in AddFstEntriesToGameList
-
Zach Hilman authored
-
Zach Hilman authored
-
Zach Hilman authored
-
Zach Hilman authored
Prompts for title type on NCA files.
-
Zach Hilman authored
-
Lioncash authored
Gets the class out of the global namespace.
-
- Aug 10, 2018
-
-
Lioncash authored
Silences a warning about truncating from size_t to u32
-
Lioncash authored
We don't need to use a heap-allocated std::vector here, given we explicitly know the bounds.
-
Lioncash authored
This is called automatically anyways.
-
Zach Hilman authored
clang-format fix
-
Zach Hilman authored
Full list of new errors and descriptions in core/loader/loader.h
-
bunnei authored
-
- Aug 09, 2018
-
-
Zach Hilman authored
-
Zach Hilman authored
-
Zach Hilman authored
-
Zach Hilman authored
-
- Aug 07, 2018
-
-
Zach Hilman authored
-
Lioncash authored
Instead, we make a proper registry class and house it within the main window, then pass it to whatever needs access to the loaded hotkeys. This way, we avoid a global variable, and don't need to initialize a std::map instance before the program can do anything.
-
Zach Hilman authored
-
Zach Hilman authored
-
Zach Hilman authored
-
Hedges authored
* GDBStub works with both Unicorn and Dynarmic now * Tidy up
-
- Aug 06, 2018
-
-
Lioncash authored
This was intermixing signed and unsigned values when they could all just be signed.
-
Lioncash authored
We can just use the file interfaces that Qt provides to prevent needing to convert to std::string.
-
Lioncash authored
The codec used by Qt for const char* and std::string don't necessarily have to be the same depending on locale. Therefore, we should be using the correct functions to do the conversions.
-
Lioncash authored
There's no need to keep these separate from one another.
-
Lioncash authored
Given the function accepts a boolean, we don't need to use an if statement here and repeat ourselves.
-
Lioncash authored
In OnMenuRecentFile() we don't need to construct a QFileInfo instance just to check if a file exists, we can just use the static member function to do that (which Qt's documentation also notes as quicker than constructing an instance). In UpdateUITheme(), we just want to try and open the file and check the success of that operation. Technically speaking, between the existence check and the open call, the file can be deleted or moved, but still appear to succeed in code. i.e. 1. Existence check -> Returns true 2. File is moved/deleted 3. Open is called, the return value of which isn't checked 4. Nonsense behavior This way we combine the existence check and the open into one.
-
Lioncash authored
Previously, when canceling out of the Load Folder dialog, a user would get an error dialog about the selected folder not containing a main file, however, by canceling out of the dialog, no selection was actually made.
-
Lioncash authored
These occur automatically without the need to call them. While we're at it, also std::move the QString instance into its member variable.
-
Lioncash authored
-