Fix null pointer dereference.

video_core/shader/ast: Minor changes to ASTPrinter

These can also trivially be made const member functions, with the
addition of a few consts.

Given all visiting functions never modify the nodes, we can trivially
make this a const member function.

vk_shader_decompiler: Mark operator() function parameters as const references

This member already has an accessor, so there's no need for it to be
public.

The returned string is simply a substring of our constexpr tabs
string_view, so we can just use a string_view here as well, since the
original string_view is guaranteed to always exist.

Now the function is fully non-allocating.

It's never used outside of this class, so we can narrow its scope down.

This can be confusing, given "ident" is generally used as a shorthand
for "identifier".

Makes a few strings nicer to read and also eliminates a bit of string
churn with operator+.

dmnt_cheat_vm: Correct register Restore and ClearRegs behavior

These parameters aren't actually modified in any way, so they can be
made const references.

Previously these were performing the same behavior as the Save and
ClearSaved opcode types.

Implement a series of ASTC formats and R4G4B4A4 format

video_core/macro_interpreter: Make definitions of most private enums/unions hidden

service/apm/controller: Minor interface changes

core: Resolve -Wreorder warnings

This allows the implementation of these types to change without
requiring a rebuild of everything that includes the macro interpreter
header.

Amends the initializer lists to be ordered in the same manner that
they're declared within the class.

Amends the initializer lists to be ordered in the same manner that
they're declared within the class.

While a map is an OK way to do lookups (and usually recommended in most
cases), this is a map that lives for the entire duration of the program
and only deallocates its contents when the program terminates.

Given the total size of the map is quite small, we can simply use a
std::array of pairs and utilize std::find_if to perform the same
behavior without loss of performance.

This eliminates a static constructor and places the data into the
read-only segment.

While we're at it, we can also handle malformed inputs instead of
directly dereferencing the resulting iterator.

This doesn't modify instance state, so it can be made const qualified.

maxwell_3d: Silence truncation warnings

video_core/texture_cache: Amend Doxygen references

texture_cache: Avoid unnecessary surface copies within PickStrategy() and TryReconstructSurface()

General fixes to Async GPU

video_core/surface: Add missing break in PixelFormatFromTextureFormat()

Prevents fallthrough into the following case.

gl_shader_decompiler: Minor cleanup-related changes

We can take these by const reference and avoid making unnecessary
copies, preventing some atomic reference count increments and
decrements.

This can be trivially fixed by making the input size a size_t.
CFGRebuildState's constructor parameter is already a std::size_t, so
this just makes the size type fully conform with it.

This is only ever used to read, but not write, the resulting string, so
we can enforce this by making it a const member function.

This allows the function to be completely non-allocating for inputs of
all sizes (i.e. there's no heap cost for an input to convert to a
std::string_view).

This is only ever used within this function, so we can narrow it's scope
down.

gl_shader_decompiler: Mark ASTDecompiler/ExprDecompiler parameters as const references where applicable

These member functions don't actually modify the input parameter, so we
can make this explicit with the use of const.

Avoids an unnecessary atomic reference count increment and decrement.

This only ever queries if the type exists within the variant, but
doesn't actually do anything with the return value. We can just use
std::holds_alternative for this use case.

Allows usages of the constructor to avoid an unnecessary copy.