1. 12 Nov, 2019 8 commits
    • Lioncash's avatar
      gdbstub: Resolve sign conversion errors · 86a1eb77
      Lioncash authored
      86a1eb77
    • Lioncash's avatar
      kernel: Resolve sign conversion warnings · 12dc9189
      Lioncash authored
      Uncovered a bug within Thread's SetCoreAndAffinityMask() where an
      unsigned variable (ideal_core) was being compared against "< 0", which
      would always be a false condition.
      
      We can also get rid of an unused function (GetNextProcessorId) which contained a sign
      mismatch warning.
      12dc9189
    • Lioncash's avatar
      file_sys: Resolve sign conversion warnings · 86c397dd
      Lioncash authored
      Resolves a few trivial sign conversion/mismatch errors.
      86c397dd
    • Lioncash's avatar
      result: Add default error code for the ResultCode(-1) case · ef060ed4
      Lioncash authored
      Will be used to reduce the overall duplication of the same magic value
      all over the codebase in following changes.
      ef060ed4
    • Lioncash's avatar
      crypto: Resolve sign-conversion warnings · 581d2e36
      Lioncash authored
      581d2e36
    • Lioncash's avatar
      result: Resolve sign-coversion warnings · 27ab9949
      Lioncash authored
      The constructor was implicitly using signed->unsigned conversions to
      produce 0xFFFFFFFF. We can just specify this explicitly with UINT32_MAX.
      27ab9949
    • Lioncash's avatar
      arm_unicorn: Resolve sign conversion warnings · 19a0abc1
      Lioncash authored
      While we're at it, this also resolves a type truncation warning as well,
      given the code was truncating from a 64-bit value to a 32-bit one.
      19a0abc1
    • Lioncash's avatar
      CMakeLists: Make most implicit type conversion warnings errors on MSVC · 96d677be
      Lioncash authored
      Quite frequently there have been cases where code has been merged into
      the core that produces warning. In order to prevent this from occurring,
      we can make the compiler flag these cases and allow our CI to flag down
      any code that would generate these warnings.
      
      This is beneficial given silent conversions from signed/unsigned can
      result in logic bugs. This forces one writing changes to be explicit
      about when signedness conversions are desirable, rather than leaving it
      up to readers' interpretation.
      
      Currently the codebase isn't in a state where it will build successfully
      with this change applied, but this will be addressed in subsequent
      follow-up changes. This set of changes will focus on making it build
      properly with these changes for MSVC as a starting point for basic
      coverage.
      96d677be
  2. 09 Nov, 2019 4 commits
  3. 08 Nov, 2019 1 commit
  4. 07 Nov, 2019 17 commits
  5. 06 Nov, 2019 10 commits