* Regression and Mode Fixes

* Review Fixes

* string_view correction

* Add operator& for FileSys::Mode

* Return std::string from SanitizePath

* Farming Simulator Fix

* Use != With mode operator&

This should be returning void, not a std::string

These aren't used externally at all, so they can be made private.

Uses the same type aliases we use for virtual addresses, and converts
one lingering usage of std::array<uint64_t, 2> to u128 for consistency.

Avoids copying a std::string instance and avoids unnecessary atomic
reference count incrementing and decrementing.

RealVfsFile inherits from VfsFile, the instance from std::make_shared is
already compatible with the function argument type, making the copy
constructor call unnecessary.

is_jump_relocation is never used within the function, so we can just
remove it.

It's sufficient to use a forward declaration instead of a direct
inclusion here.

Makes the code more uniform, and also braces cases where the body of an
unbraced conditional travels more than one line.

Makes it consistent with the other Apploader constructors, and prevents
implicit conversions.

This isn't used anywhere in the header.

It's undefined behavior to memcpy an object that isn't considered
trivially copyable, so put a compile-time check in to make sure this
doesn't occur.

Allows avoiding unnecessary copies of the vector depending on the
calling code.

While we're at it, remove a redundant no-parameter base constructor call

This is just an unused hold-over from citra, so we can get rid of this
to trim off an exposed global, among other things.

This is a holdover from citra that's essentially unused.

Forgot to include this in 22f448b6

Cleanup

Review fixes

This just returns the size of the language code buffer.

The return code should be 32-bit in size.

string_util: Get rid of separate resize() in CPToUTF16(), UTF16ToUTF8(), CodeToUTF8() and UTF8ToUTF16()

There's no need to perform the resize separately here, since the
constructor allows presizing the buffer.

Also move the empty string check before the construction of the string
to make the early out more straightforward.

This is equivalent to doing:

push_back(std::string(""));

which is likely not to cause issues, assuming a decent std::string
implementation with small-string optimizations implemented in its
design, however it's still a little unnecessary to copy that buffer
regardless. Instead, we can use emplace_back() to directly construct the
empty string within the std::vector instance, eliminating any possible
overhead from the copy.

We can just use the variant of std::string's replace() function that can
replace an occurrence with N copies of the same character, eliminating
the need to allocate a std::string containing a buffer of spaces.

We don't need to toss away the Subroutine instance after the find() call
and reconstruct another instance with the same data right after it.
Particularly give Subroutine contains a std::set.

ReplaceFileWithSubdirectory() takes a VirtualFile and a VirtualDir, but
it was being passed a string as one of its arguments. The only reason
this never caused issues is because this template isn't instantiated
anywhere yet.

This corrects an issue before it occurs.

Avoids unnecessary construction of std::string instances where
applicable.