- Apr 06, 2019
-
-
bunnei authored
- Fixes graphical issues with Chocobo's Mystery Dungeon EVERY BUDDY! - Fixes a crash with Mario Tennis Aces
-
Lioncash authored
We can just use .at(), which essentially does the same thing, but with less code.
-
Lioncash authored
Given we already ensure nothing can set the zeroth register in SetRegister(), we don't need to check if the index is zero and special case it. We can just access the register normally, since it's already going to be zero. We can also replace the assertion with .at() to perform the equivalent behavior inline as part of the API.
-
Lioncash authored
Given this doesn't actually alter internal state, this can be made a const member function.
-
Lioncash authored
Now, since we have a const qualified variant of GetPointer(), we can put it to use in ReadBlock() to retrieve the source pointer that is passed into memcpy. Now block reading may be done from a const context.
-
Lioncash authored
Allows retrieving read-only pointers from a const context externally.
-
Lioncash authored
This doesn't modify internal state, so it can be made a const member function.
-
Lioncash authored
This doesn't modify any internal state, so it can be made a const member function to allow its use in const contexts.
-
- Apr 05, 2019
-
-
Lioncash authored
-
Lioncash authored
- Use QStringLiteral where applicable. - Use const where applicable - Remove unnecessary precondition check (we already assert the pixbuf being non null)
-
Lioncash authored
We can utilize qOverload with the signal connections to make the function deducing a little less ugly.
-
Lioncash authored
Fills in the missing surface types that were marked as unknown. The order corresponds with the TextureFormat enum within video_core/texture.h. We also don't need to all of these strings as translatable (only the first string, as it's an English word).
-
Lioncash authored
This is a hold over from the 3DS error codes in Citra.
-
Lioncash authored
enum class elements from the same enum can already be compared against one another without the need for explicitly defined comparison operators.
-
Lioncash authored
The given string instance doesn't need to be copied entirely, we can just use a view instead.
-
Lioncash authored
Passing around a 64 byte data struct by value is kind of wasteful, instead pass a reference to the struct.
-
Lioncash authored
The unknown member here is actually padding due to being passed as a struct. We can do the same, and remove the need to pop a padding word.
-
Lioncash authored
I realized that I updated the documentation on SwitchBrew a while ago, but never actually updated the structs within yuzu.
-
Lioncash authored
Rather than make a full copy of the path, we can just use a string view and truncate the viewed portion of the string instead of creating a totally new truncated string.
-
- Apr 04, 2019
-
-
Lioncash authored
Temporal generally indicates a relation to time, but this is just creating a temporary, so this isn't really an accurate name for what the function is actually doing.
-
ReinUsesLisp authored
TXQ returns integer types. Shaders usually do: R0 = TXQ(); // => int R0 = static_cast<float>(R0); If we don't treat it as an integer, it will cast a binary float value as float - resulting in a corrupted number.
-
Lioncash authored
In several places, we have request parsers where there's nothing to really parse, simply because the HLE function in question operates on buffers. In these cases we can just remove these instances altogether. In the other cases, we can retrieve the relevant members from the parser and at least log them out, giving them some use.
-
Lioncash authored
Applies the override specifier where applicable. In the case of destructors that are defaulted in their definition, they can simply be removed. This also removes the unnecessary inclusions being done in audin_u and audrec_u, given their close proximity.
-
Lioncash authored
Quite a few unused includes have built up over time, particularly on core/memory.h. Removing these includes means the source files including those files will no longer need to be rebuilt if they're changed, making compilation slightly faster in this scenario.
-
Lioncash authored
While we're at it, don't use <QtGui> and <QtWidgets> and instead include exactly which headers we actually need.
-
Lioncash authored
Allows these strings to have no allocation cost when used at runtime.
-
Lioncash authored
Rather than scream that the file doesn't exist, we can clearly state what specifically doesn't exist, to avoid ambiguity, and make it easier to understand for non-primary English speakers/readers.
-
Lioncash authored
We can just make the trailing portion of the string part of the formatting, getting rid of the need to make another temporary string.
-
Lioncash authored
Simplifies the amount of string conversions necessary. We also don't need to log out what occurs here.
-
Lioncash authored
There's no need to construct a QFile instance just to check for its existence.
-
Lioncash authored
Quite a bit of these were out of sync with Switchbrew (and in some cases entirely wrong). While we're at it, also expand the section of named members. A segment within the control metadata is used to specify maximum values for the user, device, and cache storage max sizes and journal sizes. These appear to be generally used by the am service (e.g. in CreateCacheStorage, etc).
-
Lioncash authored
We need to be checking whether or not the given address is within the kernel address space or if the given address isn't word-aligned and bail in these scenarios instead of trashing any kernel state.
-
- Apr 03, 2019
-
-
Lioncash authored
For whatever reason, shared memory was being used here instead of transfer memory, which (quite clearly) will not work based off the name of the function. This corrects this wonky usage of shared memory.
-
Lioncash authored
Also amend erroneous use of size_t. We should be using u64 here.
-
ReinUsesLisp authored
-
Lioncash authored
Like the previous change, this allows Qt to handle proper translations of the UI buttons, rather than us needing to handle it.
-
Lioncash authored
Makes for shorter code, while also not requiring the buttons to be directly translated, they'll be handled by Qt itself.
-