- 19 Jul, 2018 37 commits
-
-
Lioncash authored
The reason this would never be true is that ideal_processor is a u8 and THREADPROCESSORID_DEFAULT is an s32. In this case, it boils down to how arithmetic conversions are performed before performing the comparison. If an unsigned value has a lesser conversion rank (aka smaller size) than the signed type being compared, then the unsigned value is promoted to the signed value (i.e. u8 -> s32 happens before the comparison). No sign-extension occurs here either. An alternative phrasing: Say we have a variable named core and it's given a value of -2. u8 core = -2; This becomes 254 due to the lack of sign. During integral promotion to the signed type, this still remains as 254, and therefore the condition will always be true, because no matter what value the u8 is given it will never be -2 in terms of 32 bits. Now, if one type was a s32 and one was a u32, this would be entirely different, since they have the same bit width (and the signed type would be converted to unsigned instead of the other way around) but would still have its representation preserved in terms of bits, allowing the comparison to be false in some cases, as opposed to being true all the time. --- We also get rid of two signed/unsigned comparison warnings while we're at it.
-
bunnei authored
common/misc: Deduplicate code in GetLastErrorMsg()
-
bunnei authored
externals: Update Xbyak to 5.65
-
bunnei authored
externals: Update catch to v2.2.3
-
bunnei authored
file_util: return string by const reference for GetExeDirectory()
-
bunnei authored
string_util: Remove AsciiToHex()
-
bunnei authored
savedata_factory: Make SaveDataDescriptor's DebugInfo() function a const member function
-
bunnei authored
partition_filesystem: Ensure all class members of PartitionFilesystem are initialized
-
bunnei authored
content_archive: Minor changes
-
bunnei authored
vfs: Deduplicate accumulation code in VfsDirectory's GetSize()
-
bunnei authored
gl_state: Temporarily disable culling and depth test.
-
Lioncash authored
Android and macOS have supported thread_local for quite a while, but most importantly is that we don't even really need it. Instead of using a thread-local buffer, we can just return a non-static buffer as a std::string, avoiding the need for that quality entirely.
-
Lioncash authored
Keeps the JIT assembler library up to date and ensures we don't run into any issues that may have been resolved.
-
Lioncash authored
Keeps the unit-testing library up to date.
-
Lioncash authored
This disallows modifying the internal string buffer (which shouldn't be modified anyhow).
-
bunnei authored
externals: Update dynarmic to 5a91c94.
-
Lioncash authored
Easy TODO
-
bunnei authored
address_arbiter: Correct assignment within an assertion statement in WakeThreads()
-
bunnei authored
core/memory, core/hle/kernel: Use std::move where applicable
-
Lioncash authored
This function doesn't alter class state.
-
Lioncash authored
Previously is_hfs and pfs_header members wouldn't be initialized in the constructor, as they were stored in locals instead. This would result in things like GetName() and PrintDebugInfo() behaving incorrectly. While we're at it, initialize the members to deterministic values as well, in case loading ever fails.
-
bunnei authored
-
Lioncash authored
There's no need to take this by value when it's possible to avoid unnecessary copies entirely like this.
-
Lioncash authored
-
bunnei authored
-
Lioncash authored
Gets rid of unnecessary atomic reference count incrementing and decrementing.
-
Lioncash authored
We can just use a generic lambda to avoid writing the same thing twice.
-
bunnei authored
service/prepo: Add missing header guard
-
bunnei authored
externals: update fmt to version 5.1.0
-
bunnei authored
vm_manager: Add missing commas to string literal array elements in GetMemoryStateName()
-
bunnei authored
core/memory: Remove unused function GetSpecialHandlers() and an unused variable in ZeroBlock()
-
bunnei authored
core: Don't construct instance of Core::System, just to access its live instance
-
bunnei authored
decoders: Fix calc of swizzle image_width_in_gobs.
-
bunnei authored
hle/filesystem: Amend trace log in OpenSaveData() to compile in debug mode
-
bunnei authored
game_list: Make ContainsAllWords an internally linked non-member function
-
bunnei authored
-
Zach Hilman authored
* Virtual Filesystem * Fix delete bug and documentate * Review fixes + other stuff * Fix puyo regression
-
- 18 Jul, 2018 3 commits