Skip to content
Snippets Groups Projects
  1. Feb 16, 2019
    • Lioncash's avatar
      video_core: Remove usages of System::GetInstance() within the engines · a8fa5019
      Lioncash authored
      Avoids the use of the global accessor in favor of explicitly making the
      system a dependency within the interface.
      a8fa5019
    • Lioncash's avatar
      core_timing: Convert core timing into a class · bd983414
      Lioncash authored
      Gets rid of the largest set of mutable global state within the core.
      This also paves a way for eliminating usages of GetInstance() on the
      System class as a follow-up.
      
      Note that no behavioral changes have been made, and this simply extracts
      the functionality into a class. This also has the benefit of making
      dependencies on the core timing functionality explicit within the
      relevant interfaces.
      bd983414
  2. Feb 12, 2019
  3. Feb 07, 2019
  4. Jan 17, 2019
    • Lioncash's avatar
      core/frontend/applets/web_browser: Make OpenPage() non-const · a6610256
      Lioncash authored
      This is a function that definitely doesn't always have a non-modifying
      behavior across all implementations, so this should be made non-const.
      
      This gets rid of the need to mark data members as mutable to work around
      the fact mutating data members needs to occur.
      a6610256
  5. Jan 08, 2019
  6. Dec 28, 2018
  7. Dec 03, 2018
  8. Nov 22, 2018
    • Lioncash's avatar
      core: Relocate CPU core management to its own class · 232d95b5
      Lioncash authored
      Keeps the CPU-specific behavior from being spread throughout the main
      System class. This will also act as the home to contain member functions
      that perform operations on all cores. The reason for this being that the
      following pattern is sort of prevalent throughout sections of the
      codebase:
      
      If clearing the instruction cache for all 4 cores is necessary:
      
      Core::System::GetInstance().ArmInterface(0).ClearInstructionCache();
      Core::System::GetInstance().ArmInterface(1).ClearInstructionCache();
      Core::System::GetInstance().ArmInterface(2).ClearInstructionCache();
      Core::System::GetInstance().ArmInterface(3).ClearInstructionCache();
      
      This is kind of... well, silly to copy around whenever it's needed.
      especially when it can be reduced down to a single line.
      
      This change also puts the basics in place to begin "ungrafting" all of the
      forwarding member functions from the System class that are used to
      access CPU state or invoke CPU-specific behavior. As such, this change
      itself makes no changes to the direct external interface of System. This
      will be covered by another changeset.
      232d95b5
  9. Nov 18, 2018
  10. Oct 30, 2018
  11. Oct 28, 2018
  12. Oct 18, 2018
  13. Oct 15, 2018
  14. Oct 13, 2018
    • Lioncash's avatar
      filesystem: Make CreateFactories() and InstallInterface() take a VfsFilesystem... · 0149162d
      Lioncash authored
      filesystem: Make CreateFactories() and InstallInterface() take a VfsFilesystem instance by reference
      
      Neither of these functions alter the ownership of the provided pointer,
      so we can simply make the parameters a reference rather than a direct
      shared pointer alias. This way we also disallow passing incorrect memory values like
      nullptr.
      0149162d
  15. Oct 10, 2018
    • Lioncash's avatar
      kernel/thread: Use a regular pointer for the owner/current process · 5c040859
      Lioncash authored
      There's no real need to use a shared pointer in these cases, and only
      makes object management more fragile in terms of how easy it would be to
      introduce cycles. Instead, just do the simple thing of using a regular
      pointer. Much of this is just a hold-over from citra anyways.
      
      It also doesn't make sense from a behavioral point of view for a
      process' thread to prolong the lifetime of the process itself (the
      process is supposed to own the thread, not the other way around).
      5c040859
  16. Sep 29, 2018
  17. Sep 26, 2018
  18. Sep 15, 2018
  19. Sep 07, 2018
    • Lioncash's avatar
      core: Migrate current_process pointer to the kernel · 3f17fe71
      Lioncash authored
      Given we now have the kernel as a class, it doesn't make sense to keep
      the current process pointer within the System class, as processes are
      related to the kernel.
      
      This also gets rid of a subtle case where memory wouldn't be freed on
      core shutdown, as the current_process pointer would never be reset,
      causing the pointed to contents to continue to live.
      3f17fe71
  20. Sep 06, 2018
    • Lioncash's avatar
      core/core: Remove unnecessary sm/controller include · 56ab6080
      Lioncash authored
      The only reason this include was necessary, was because the constructor
      wasn't defaulted in the cpp file and the compiler would inline it
      wherever it was used. However, given Controller is forward declared, all
      those inlined constructors would see an incomplete type, causing a
      compilation failure. So, we just place the constructor in the cpp file,
      where it can see the complete type definition, allowing us to remove
      this include.
      56ab6080
  21. Sep 04, 2018
  22. Sep 02, 2018
    • Lioncash's avatar
      vfs_real: Forward declare IOFile · a4053731
      Lioncash authored
      Eliminates the need to rebuild some source files if the file_util header
      ever changes. This also uncovered some indirect inclusions, which have
      also been fixed.
      a4053731
  23. Aug 31, 2018
    • Lioncash's avatar
      core/core: Replace includes with forward declarations where applicable · 4a587b81
      Lioncash authored
      The follow-up to e2457418, which
      replaces most of the includes in the core header with forward declarations.
      
      This makes it so that if any of the headers the core header was
      previously including change, then no one will need to rebuild the bulk
      of the core, due to core.h being quite a prevalent inclusion.
      
      This should make turnaround for changes much faster for developers.
      4a587b81
    • Lioncash's avatar
      core: Make the main System class use the PImpl idiom · e2457418
      Lioncash authored
      core.h is kind of a massive header in terms what it includes within
      itself. It includes VFS utilities, kernel headers, file_sys header,
      ARM-related headers, etc. This means that changing anything in the
      headers included by core.h essentially requires you to rebuild almost
      all of core.
      
      Instead, we can modify the System class to use the PImpl idiom, which
      allows us to move all of those headers to the cpp file and forward
      declare the bulk of the types that would otherwise be included, reducing
      compile times. This change specifically only performs the PImpl portion.
      e2457418
  24. Aug 29, 2018
    • Lioncash's avatar
      kernel: Eliminate kernel global state · 0cbcd6ec
      Lioncash authored
      As means to pave the way for getting rid of global state within core,
      This eliminates kernel global state by removing all globals. Instead
      this introduces a KernelCore class which acts as a kernel instance. This
      instance lives in the System class, which keeps its lifetime contained
      to the lifetime of the System class.
      
      This also forces the kernel types to actually interact with the main
      kernel instance itself instead of having transient kernel state placed
      all over several translation units, keeping everything together. It also
      has a nice consequence of making dependencies much more explicit.
      
      This also makes our initialization a tad bit more correct. Previously we
      were creating a kernel process before the actual kernel was initialized,
      which doesn't really make much sense.
      
      The KernelCore class itself follows the PImpl idiom, which allows
      keeping all the implementation details sealed away from everything else,
      which forces the use of the exposed API and allows us to avoid any
      unnecessary inclusions within the main kernel header.
      0cbcd6ec
  25. Aug 24, 2018
  26. Aug 12, 2018
  27. Aug 10, 2018
  28. Aug 09, 2018
Loading