Resolves a warning where not all control paths return a value.

main/profile_select: Don't ask for profile when there's only one.

sdl_impl: Fix controller reconnection issues

video_core: Fix instances where msbuild always regenerated host shaders

service: time: Update current time with changes to RTC setting.

Should finally resolve building with clang.

It turns out that after a controller is disconnected, there is a chance that events from the previous controller are sent/processed after it has been disconnected.
This causes the previously disconnected controller to reappear as connected due to GetSDLJoystickBySDLID() emplacing this controller back to the map.

Fix this by only returning an SDLJoystick if and only if it exists in the map.

video_core: Conditially activate relevant compiler warnings

Resolves the clang build issue in a more unintrusive way.

Revert "core: Fix clang build"

These compiler flags aren't shared with clang, so specifying these flags
unconditionally can lead to a bit of warning spam.

While we're in the area, we can also enable -Wunused-but-set-parameter
given this is almost always a bug.

This slipped through the cracks due to another change being merged
before the compiler flag changes.

gl_arb_decompiler: Implement robust buffer operations

core: Fix clang build

nifm: GetAppletInfo stub

configure_input_player: Fix modifier buttons

sdl_impl: Erase the SDLJoystick entry after removing a controller

Fix them for real this time, now they finally work.

This emulates the behavior we get on GLSL with regular SSBOs with a
pointer + length pair. It aims to be consistent with the crashes we
might get.

Out of bounds stores are ignored. Atomics are ignored and return zero.
Reads return zero.

Fixes crash for Catherine Full Body

kernel: Implement host thread register methods without locking

filesystem: Fix CreateDirectory and DeleteFile

renderer_vulkan: Create and properly use Vulkan 1.0 instances when 1.1 is not available

core: Add boxcat sources with target_sources

hle: service: nvdrv: Implement nvhost_as_gpu::FreeSpace.

Same behavior, minus a script variable.

mii/manager: Make use of unused lower bound in GetRandomValue()

vk_graphics_pipeline: Manage primitive topology as fixed state

Recent changes to the build system that made more warnings be flagged as
errors caused building via clang to break.

Fixes #4795

Previously, the lower bound wasn't being used and zero was being used as
the lower bound every time this function was called.

This affects the outcome of some of the randomized entries a little bit,
for example, the lower-bound for beard and mustache flags was supposed
to be 1, not 0.

Aside from these cases, the bug didn't affect anything else.

service: bcat: Check client connection before interacting with socket.

udp/client: Take std::function by const reference with TestCommunication()

- Fixes a crash when BCAT service is offline.

Same behavior, but makes the callback list nicer to look at.

Avoids redundant copies.

Previously, disconnecting a controller still leaves a null SDLJoystick entry within the vector of SDLJoysticks mapped by GUID.
When a DirectInput device of the same GUID is reconnected, it adds that device to a new port causing non-detectable input.
Furthermore, opening the "Configure" menu would cause yuzu to crash since it first tries to resolve the name of a null SDLJoystick entry that was not removed.
Resolve this by properly erasing the SDLJoystick entry from the vector.

input_common/CMakeLists: Make some warnings errors