Skip to content
Snippets Groups Projects
  1. Dec 19, 2018
  2. Nov 29, 2018
  3. Nov 26, 2018
  4. Nov 14, 2018
    • Lioncash's avatar
      nfp: Correct erroneous sizeof expression within GetTagInfo() · b4f63db0
      Lioncash authored
      The previous expression would copy sizeof(size_t) amount of bytes (8 on
      a 64-bit platform) rather than the full 10 bytes comprising the uuid
      member.
      
      Given the source and destination types are the same, we can just use an
      assignment here instead.
      b4f63db0
  5. Oct 24, 2018
  6. Oct 23, 2018
    • David's avatar
      Added Amiibo support (#1390) · 50e4e81f
      David authored
      * Fixed conflict with nfp
      
      * Few fixups for nfc
      
      * Conflict 2
      
      * Fixed AttachAvailabilityChangeEvent
      
      * Conflict 3
      
      * Fixed byte padding
      
      * Refactored amiibo to not reside in "System"
      
      * Removed remaining references of nfc from system
      
      * used enum for Nfc GetStateOld
      
      * Added missing newline
      
      * Moved file operations to front end
      
      * Conflict 4
      
      * Amiibos now use structs and added mutexes
      
      * Removed amiibo_path
      50e4e81f
  7. Oct 10, 2018
  8. Sep 25, 2018
  9. Sep 11, 2018
    • Lioncash's avatar
      hle/service: Default constructors and destructors in the cpp file where applicable · 6ac955a0
      Lioncash authored
      When a destructor isn't defaulted into a cpp file, it can cause the use
      of forward declarations to seemingly fail to compile for non-obvious
      reasons. It also allows inlining of the construction/destruction logic
      all over the place where a constructor or destructor is invoked, which
      can lead to code bloat. This isn't so much a worry here, given the
      services won't be created and destroyed frequently.
      
      The cause of the above mentioned non-obvious errors can be demonstrated
      as follows:
      
      ------- Demonstrative example, if you know how the described error happens, skip forwards -------
      
      Assume we have the following in the header, which we'll call "thing.h":
      
      \#include <memory>
      
      // Forward declaration. For example purposes, assume the definition
      // of Object is in some header named "object.h"
      class Object;
      
      class Thing {
      public:
          // assume no constructors or destructors are specified here,
          // or the constructors/destructors are defined as:
          //
          // Thing() = default;
          // ~Thing() = default;
          //
      
          // ... Some interface member functions would be defined here
      
      private:
          std::shared_ptr<Object> obj;
      };
      
      If this header is included in a cpp file, (which we'll call "main.cpp"),
      this will result in a compilation error, because even though no
      destructor is specified, the destructor will still need to be generated by
      the compiler because std::shared_ptr's destructor is *not* trivial (in
      other words, it does something other than nothing), as std::shared_ptr's
      destructor needs to do two things:
      
      1. Decrement the shared reference count of the object being pointed to,
         and if the reference count decrements to zero,
      
      2. Free the Object instance's memory (aka deallocate the memory it's
         pointing to).
      
      And so the compiler generates the code for the destructor doing this inside main.cpp.
      
      Now, keep in mind, the Object forward declaration is not a complete type. All it
      does is tell the compiler "a type named Object exists" and allows us to
      use the name in certain situations to avoid a header dependency. So the
      compiler needs to generate destruction code for Object, but the compiler
      doesn't know *how* to destruct it. A forward declaration doesn't tell
      the compiler anything about Object's constructor or destructor. So, the
      compiler will issue an error in this case because it's undefined
      behavior to try and deallocate (or construct) an incomplete type and
      std::shared_ptr and std::unique_ptr make sure this isn't the case
      internally.
      
      Now, if we had defaulted the destructor in "thing.cpp", where we also
      include "object.h", this would never be an issue, as the destructor
      would only have its code generated in one place, and it would be in a
      place where the full class definition of Object would be visible to the
      compiler.
      
      ---------------------- End example ----------------------------
      
      Given these service classes are more than certainly going to change in
      the future, this defaults the constructors and destructors into the
      relevant cpp files to make the construction and destruction of all of
      the services consistent and unlikely to run into cases where forward
      declarations are indirectly causing compilation errors. It also has the
      plus of avoiding the need to rebuild several services if destruction
      logic changes, since it would only be necessary to recompile the single
      cpp file.
      6ac955a0
  10. Aug 29, 2018
    • Lioncash's avatar
      kernel: Eliminate kernel global state · 0cbcd6ec
      Lioncash authored
      As means to pave the way for getting rid of global state within core,
      This eliminates kernel global state by removing all globals. Instead
      this introduces a KernelCore class which acts as a kernel instance. This
      instance lives in the System class, which keeps its lifetime contained
      to the lifetime of the System class.
      
      This also forces the kernel types to actually interact with the main
      kernel instance itself instead of having transient kernel state placed
      all over several translation units, keeping everything together. It also
      has a nice consequence of making dependencies much more explicit.
      
      This also makes our initialization a tad bit more correct. Previously we
      were creating a kernel process before the actual kernel was initialized,
      which doesn't really make much sense.
      
      The KernelCore class itself follows the PImpl idiom, which allows
      keeping all the implementation details sealed away from everything else,
      which forces the use of the exposed API and allows us to avoid any
      unnecessary inclusions within the main kernel header.
      0cbcd6ec
  11. Jul 03, 2018
  12. Jun 06, 2018
  13. Jun 04, 2018
  14. May 13, 2018
  15. Apr 27, 2018
  16. Apr 24, 2018
  17. Apr 23, 2018
  18. Apr 22, 2018
  19. Apr 20, 2018
  20. Mar 30, 2018
  21. Feb 19, 2018
Loading