1. 07 Dec, 2020 3 commits
    • comex's avatar
      network, sockets: Replace `POLL_IN`, `POLL_OUT`, etc. constants with an `enum class PollEvents` · 0791082b
      comex authored
      Actually, two enum classes, since for some reason there are two separate
      yet identical `PollFD` types used in the codebase.  I get that one is
      ABI-compatible with the Switch while the other is an abstract type used
      for the host, but why not use `WSAPOLLFD` directly for the latter?
      
      Anyway, why make this change?  Because on Apple platforms, `POLL_IN`,
      `POLL_OUT`, etc. (with an underscore) are defined as macros in
      <sys/signal.h>.  (This is inherited from FreeBSD.)  So defining
      a variable with the same name causes a compile error.
      
      I could just rename the variables, but while I was at it I thought I
      might as well switch to an enum for stronger typing.
      
      Also, change the type used for values copied directly to/from the
      `events` and `revents` fields of the host *native*
      `pollfd`/`WSASPOLLFD`, from `u32` to `short`, as `short` is the correct
      canonical type on both Unix and Windows.
      0791082b
    • LC's avatar
      Merge pull request #5155 from comex/xx-default · 5933667c
      LC authored
      Fix "explicitly defaulted but implicitly deleted" warning
      5933667c
    • comex's avatar
      Fix "explicitly defaulted but implicitly deleted" warning · e31cb504
      comex authored
      `PhysicalCore`'s move assignment operator was declared as `= default`,
      but was implicitly deleted because `PhysicalCore` has fields
      of reference type.  Switch to explicitly deleting it to avoid a Clang
      warning.
      
      The move *constructor* is still defaulted, and is required to exist due
      to the use of `std::vector<PhysicalCore>`.
      e31cb504
  2. 06 Dec, 2020 7 commits
  3. 05 Dec, 2020 14 commits
  4. 04 Dec, 2020 4 commits
  5. 03 Dec, 2020 12 commits