gl_shader_decompiler: Use a std::string_view with GetDeclarationWithSuffix()

This allows the function to be completely non-allocating for inputs of
all sizes (i.e. there's no heap cost for an input to convert to a
std::string_view).