parallel download almost done. still has strange bug

packageManager.go

@@ -8,6 +8,7 @@ import (
 	"os"
 	"os/exec"
 	"strings"
+	"sync"
 )
 
 // Scan a directory recursively, and parse `**/*.csproj`, to list all referenced nuget packages. (in CoreXT reference format)
@@ -31,16 +32,25 @@ func SyncPackages(nugetConfigPath, localRepoPath string, allDeps []dependencyIte
 
 	// Prepare nuget local repo
 	depsToSync := depsDeduplicate(allDeps)
-	for index, dep := range depsToSync {
-		// TODO: parallelize me!
-		log.Printf("[%v/%v] Downloading pkg: %v:%v as var %v", index, len(depsToSync), dep.pkgName, dep.targetNetVer, dep.envName)
 
-		cmd := exec.Command("nuget-download-package", dep.pkgName, dep.targetNetVer, localRepoPath, nugetConfigPath)
-		stdout, err := cmd.CombinedOutput()
-		log.Println(string(stdout))
-		// We can do nothing on failure. usually, if envName is NULL, we need not install it at all.
-		logErrorIfAny(err, "EXEC command")
+	var wg sync.WaitGroup
+	for index_, dep_ := range depsToSync {
+		wg.Add(1)
+		go func(index int, dep dependencyItem) {
+			defer wg.Done()
+			log.Printf("[%v/%v] Begin downloading: %v:%v as var %v", index, len(depsToSync), dep.pkgName, dep.targetNetVer, dep.envName)
+			log.Println("nuget-download-package", dep.pkgName, dep.targetNetVer, localRepoPath, nugetConfigPath)
+
+			cmd := exec.Command("nuget-download-package", dep.pkgName, dep.targetNetVer, localRepoPath, nugetConfigPath)
+			stdout, err := cmd.CombinedOutput()
+			log.Println(string(stdout))
+			// We can do nothing on failure. usually, if envName is NULL, we need not install it at all.
+			logErrorIfAny(err, "EXEC command")
+
+			log.Printf("[%v/%v] End downloading: %v:%v as var %v", index, len(depsToSync), dep.pkgName, dep.targetNetVer, dep.envName)
+		}(index_, dep_)
 	}
+	wg.Wait()
 }
 
 // Given package name, this function lookup the localRepoPath, and returns path to a good package version.

tools/nuget-download-package/main.go

@@ -197,22 +197,29 @@ func decidePackageVersion(frameworkVersion, packageVersion string, indexJsons, i
 				defer func() {recover()} () // try parse, skip this entry on error
 				jPkgVersionItem := jPkgVersionItem_.(map[string]interface{})
 				jCatalogEntry := jPkgVersionItem["catalogEntry"].(map[string]interface{})
-				j5 := jCatalogEntry["dependencyGroups"].([]interface{})
 				myVersionText := jCatalogEntry["version"].(string)
+				// log.Println("DEBUG: reaching " + myVersionText)
 
 				// Let's check if this version is ok
 				thisPkgVersionIsOk := false
 
 				if frameworkVersion != "" {
-					for _, j6 := range j5 {
-						j7 := j6.(map[string]interface{})
-						if j8, ok := j7["targetFramework"]; ok {
-							thisPkgVersionIsOk = frameworkVersion == netVersionNugetFormatToStandardFormat(j8.(string))
-							break
-						} else {
-							// if not ok, then this pkgVersion has no targetFramework limitation.
-							thisPkgVersionIsOk = true
+					if j5, ok := jCatalogEntry["dependencyGroups"]; ok {
+						for _, j6 := range j5.([]interface{}) {
+							j7 := j6.(map[string]interface{})
+							if j8, ok := j7["targetFramework"]; ok {
+								if frameworkVersion == netVersionNugetFormatToStandardFormat(j8.(string)) {
+									thisPkgVersionIsOk = true
+									break
+								}
+							} else {
+								// this pkgVersion has no targetFramework limitation.
+								thisPkgVersionIsOk = true
+							}
 						}
+					} else {
+						// no dependencyGroups at all
+						thisPkgVersionIsOk = true
 					}
 				}
 
@@ -221,6 +228,7 @@ func decidePackageVersion(frameworkVersion, packageVersion string, indexJsons, i
 				}
 
 				if thisPkgVersionIsOk {
+					// log.Println("DEBUG: good " + myVersionText)
 					// This version is ok! Log it.
 					myVersionUrl := jPkgVersionItem["packageContent"].(string)
 					if version.CompareSimple(myVersionText, maxAvailableVersion) == 1 {
@@ -263,6 +271,10 @@ func main() {
 		pkgVer, targetUrl, targetUrlLogin = decidePackageVersion("", pkgVerOrNetVer, indexJsons, indexJsons_Login)
 	}
 
+	if pkgVer == "" {
+		log.Println("Error: can not find a valid pkgVer for " + pkgName + ":" + pkgVerOrNetVer)
+		os.Exit(2)
+	}
 	log.Println("Using pkgVer " + pkgVer + " from " + targetUrl)
 
 	pkgBaseDir := filepath.Join(localRepoDir, pkgName, pkgVer)

tools/nuget-download-package/unzip.go

@@ -4,6 +4,7 @@ import (
 	"archive/zip"
 	"fmt"
 	"io"
+	"log"
 	"os"
 	"path/filepath"
 	"strings"
@@ -11,7 +12,7 @@ import (
 
 
 func Extract(src, dest string) error {
-	fmt.Println("Extracting " + src + "...")
+	log.Println("Extracting " + src + "...")
 
 	r, err := zip.OpenReader(src)
 	if err != nil {