- Jul 19, 2018
-
-
Lioncash authored
We were using a second std::vector as a buffer to convert another std::vector's data into a byte sequence, however we can just use pointers to the original data and use them directly with WriteBuffer, which avoids copying the data at all into a separate std::vector. We simply cast the pointers to u8* (which is allowed by the standard, given std::uint8_t is an alias for unsigned char on platforms that we support).
-
Lioncash authored
Prevents implicit conversions.
-
Lioncash authored
Gets rid of relying on indirect inclusions.
-
Lioncash authored
-
Lioncash authored
Previously we were just copying the data whole-sale, even if the length was less than the total data size. This effectively makes the actual_data vector useless, which is likely not intended. Instead, amend this to only copy the given length amount of data. At the same time, we can avoid zeroing out the data before using it by passing iterators to the constructor instead of a size.
-
bunnei authored
externals: Update dynarmic to 5a91c94.
-
bunnei authored
address_arbiter: Correct assignment within an assertion statement in WakeThreads()
-
bunnei authored
core/memory, core/hle/kernel: Use std::move where applicable
-
bunnei authored
-
bunnei authored
service/prepo: Add missing header guard
-
bunnei authored
externals: update fmt to version 5.1.0
-
bunnei authored
vm_manager: Add missing commas to string literal array elements in GetMemoryStateName()
-
bunnei authored
core/memory: Remove unused function GetSpecialHandlers() and an unused variable in ZeroBlock()
-
bunnei authored
core: Don't construct instance of Core::System, just to access its live instance
-
bunnei authored
decoders: Fix calc of swizzle image_width_in_gobs.
-
bunnei authored
hle/filesystem: Amend trace log in OpenSaveData() to compile in debug mode
-
bunnei authored
game_list: Make ContainsAllWords an internally linked non-member function
-
bunnei authored
-
Zach Hilman authored
* Virtual Filesystem * Fix delete bug and documentate * Review fixes + other stuff * Fix puyo regression
-
- Jul 18, 2018
-
-
Lioncash authored
-
Lioncash authored
-
Lioncash authored
Without these, this would perform concatenation, which is definitely not what we want here.
-
Lioncash authored
Avoids pointless copies
-
Lioncash authored
This makes it a compilation error to construct additional instances of the System class directly, preventing accidental wasteful constructions over and over.
-
Lioncash authored
This would result in a lot of allocations and related object construction, just to toss it all away immediately after the call. These are definitely not intentional, and it was intended that all of these should have been accessing the static function GetInstance() through the name itself, not constructed instances.
-
Lioncash authored
Previously, we were on 4.1.0, which was a major version behind.
-
Lioncash authored
Previously this wouldn't compile, since no such function named SaveStructDebugInfo() exists.
-
bunnei authored
Touchscreen Support
-
Lioncash authored
This function actually depends on no internal class state, so it doesn't even need to be a part of the class interface.
-
Zach Hilman authored
-
Zach Hilman authored
-
bunnei authored
game_list: Make containsAllWords a const member function
-
bunnei authored
Telemetry: Minor changes
-
bunnei authored
game_list: Remove unnecessary QString initialization in KeyReleaseEater
-
bunnei authored
astc: Minor changes
-
Lioncash authored
We can just take the value parameter by value which allows both moving into it, and copies at the same time, depending on the calling code.
-
Lioncash authored
These operators don't modify internal class state, so they can be made const member functions. While we're at it, drop the unnecessary inline keywords. Member functions that are defined in the class declaration are already inline by default.
-
bunnei authored
Implement buffer cropping and default to handheld mode
-
Lioncash authored
This provides the equivalent behavior, but without as much boilerplate. While we're at it, explicitly default the move constructor, since we have a move-assignment operator defined.
-