Skip to content
Snippets Groups Projects
  • Yuri Kunde Schlesner's avatar
    HLE: Revamp error handling throrough the HLE code · c2588403
    Yuri Kunde Schlesner authored
    All service calls in the CTR OS return result codes indicating the
    success or failure of the call. Previous to this commit, Citra's HLE
    emulation of services and the kernel universally either ignored errors
    or returned dummy -1 error codes.
    
    This commit makes an initial effort to provide an infrastructure for
    error reporting and propagation which can be use going forward to make
    HLE calls accurately return errors as the original system. A few parts
    of the code have been updated to use the new system where applicable.
    
    One part of this effort is the definition of the `ResultCode` type,
    which provides facilities for constructing and parsing error codes in
    the structured format used by the CTR.
    
    The `ResultVal` type builds on `ResultCode` by providing a container for
    values returned by function that can report errors. It enforces that
    correct error checking will be done on function returns by preventing
    the use of the return value if the function returned an error code.
    
    Currently this change is mostly internal since errors are still
    suppressed on the ARM<->HLE border, as a temporary compatibility hack.
    As functionality is implemented and tested this hack can be eventually
    removed.
    c2588403