Skip to content
Snippets Groups Projects
  • Lioncash's avatar
    file_sys/registered_cache: Use unique_ptr and regular pointers instead of... · 39ae73b3
    Lioncash authored
    file_sys/registered_cache: Use unique_ptr and regular pointers instead of shared_ptrs where applicable
    
    The data retrieved in these cases are ultimately chiefly owned by either
    the RegisteredCache instance itself, or the filesystem factories. Both
    these should live throughout the use of their contained data. If they
    don't, it should be considered an interface/design issue, and using
    shared_ptr instances here would mask that, as the data would always be
    prolonged after the main owner's lifetime ended.
    
    This makes the lifetime of the data explicit and makes it harder to
    accidentally create cyclic references. It also makes the interface
    slightly more flexible than the previous API, as a shared_ptr can be
    created from a unique_ptr, but not the other way around, so this allows
    for that use-case if it ever becomes necessary in some form.
    39ae73b3