From c5129a3a58956256c72bf3915a2a2ac93a1f58e3 Mon Sep 17 00:00:00 2001
From: Lioncash <mathew1800@gmail.com>
Date: Tue, 14 May 2019 08:09:15 -0400
Subject: [PATCH] video_core/gpu_thread: Remove redundant copy constructor for
 CommandDataContainer

std::move within a copy constructor (on a data member that isn't
mutable) will always result in a copy. Because of that, the behavior of
this copy constructor is identical to the one that would be generated
automatically by the compiler, so we can remove it.
---
 src/video_core/gpu_thread.h | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/video_core/gpu_thread.h b/src/video_core/gpu_thread.h
index cc14527c79..64a3335ba6 100644
--- a/src/video_core/gpu_thread.h
+++ b/src/video_core/gpu_thread.h
@@ -81,12 +81,6 @@ struct CommandDataContainer {
     CommandDataContainer(CommandData&& data, u64 next_fence)
         : data{std::move(data)}, fence{next_fence} {}
 
-    CommandDataContainer& operator=(const CommandDataContainer& t) {
-        data = std::move(t.data);
-        fence = t.fence;
-        return *this;
-    }
-
     CommandData data;
     u64 fence{};
 };
-- 
GitLab