From 8af3ebb149b057b40bc4efd5bae2b9cb70b2066c Mon Sep 17 00:00:00 2001
From: bunnei <bunneidev@gmail.com>
Date: Sun, 9 Jul 2017 13:49:51 -0400
Subject: [PATCH] telemetry_session: Use TelemetryJson to submit real
telemetry.
---
src/core/telemetry_session.cpp | 4 ++--
src/web_service/telemetry_json.cpp | 2 --
src/web_service/telemetry_json.h | 2 +-
3 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/src/core/telemetry_session.cpp b/src/core/telemetry_session.cpp
index ddc8b262e2..1ba0a698d6 100644
--- a/src/core/telemetry_session.cpp
+++ b/src/core/telemetry_session.cpp
@@ -6,12 +6,12 @@
#include "common/scm_rev.h"
#include "core/telemetry_session.h"
+#include "web_services/telemetry_json.h"
namespace Core {
TelemetrySession::TelemetrySession() {
- // TODO(bunnei): Replace with a backend that logs to our web service
- backend = std::make_unique<Telemetry::NullVisitor>();
+ backend = std::make_unique<WebService::TelemetryJson>();
// Log one-time session start information
const auto duration{std::chrono::steady_clock::now().time_since_epoch()};
diff --git a/src/web_service/telemetry_json.cpp b/src/web_service/telemetry_json.cpp
index c61522ff1d..a2d007e779 100644
--- a/src/web_service/telemetry_json.cpp
+++ b/src/web_service/telemetry_json.cpp
@@ -9,8 +9,6 @@
namespace WebService {
-TelemetryJson::TelemetryJson() {}
-
template <class T>
void TelemetryJson::Serialize(Telemetry::FieldType type, const std::string& name, T value) {
sections[static_cast<u8>(type)][name] = value;
diff --git a/src/web_service/telemetry_json.h b/src/web_service/telemetry_json.h
index cc511cdd1b..39038b4f9c 100644
--- a/src/web_service/telemetry_json.h
+++ b/src/web_service/telemetry_json.h
@@ -17,7 +17,7 @@ namespace WebService {
*/
class TelemetryJson : public Telemetry::VisitorInterface {
public:
- TelemetryJson();
+ TelemetryJson() = default;
~TelemetryJson() = default;
void Visit(const Telemetry::Field<bool>& field) override;
--
GitLab