From 441b5b97bd4f0c01b33785ef4d32b3ef3d7ea4fa Mon Sep 17 00:00:00 2001
From: Lioncash <mathew1800@gmail.com>
Date: Tue, 16 Oct 2018 13:13:40 -0400
Subject: [PATCH] content_archive: Make IsValidNCA() an internally linked
function
This is only ever used within the cpp file, so it can just be an
internal function.
---
src/core/file_sys/content_archive.cpp | 2 +-
src/core/file_sys/content_archive.h | 2 --
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/core/file_sys/content_archive.cpp b/src/core/file_sys/content_archive.cpp
index a6bd3369c3..6ce1cb0aec 100644
--- a/src/core/file_sys/content_archive.cpp
+++ b/src/core/file_sys/content_archive.cpp
@@ -97,7 +97,7 @@ union NCASectionHeader {
};
static_assert(sizeof(NCASectionHeader) == 0x200, "NCASectionHeader has incorrect size.");
-bool IsValidNCA(const NCAHeader& header) {
+static bool IsValidNCA(const NCAHeader& header) {
// TODO(DarkLordZach): Add NCA2/NCA0 support.
return header.magic == Common::MakeMagic('N', 'C', 'A', '3');
}
diff --git a/src/core/file_sys/content_archive.h b/src/core/file_sys/content_archive.h
index e5d3d3c6ab..1c903cd3ff 100644
--- a/src/core/file_sys/content_archive.h
+++ b/src/core/file_sys/content_archive.h
@@ -73,8 +73,6 @@ inline bool IsDirectoryExeFS(const std::shared_ptr<VfsDirectory>& pfs) {
return pfs->GetFile("main") != nullptr && pfs->GetFile("main.npdm") != nullptr;
}
-bool IsValidNCA(const NCAHeader& header);
-
// An implementation of VfsDirectory that represents a Nintendo Content Archive (NCA) conatiner.
// After construction, use GetStatus to determine if the file is valid and ready to be used.
class NCA : public ReadOnlyVfsDirectory {
--
GitLab